This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
add KV Table iterator bool operator #987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larryk85
suggested changes
Oct 27, 2020
larryk85
suggested changes
Nov 5, 2020
| @@ -462,6 +462,8 @@ namespace internal { | |||
| return eosio::key_type{(char*)buffer, actual_value_size}; | |||
| } | |||
|
|
|||
| bool valid() const { return itr_stat != status::iterator_erased; } | |||
There was a problem hiding this comment.
Shouldn't this be itr_stat == status::iterator_ok?
There was a problem hiding this comment.
Should the iterator end() be true or false?
There was a problem hiding this comment.
Shouldn't this be
itr_stat == status::iterator_ok?
Updated.
There was a problem hiding this comment.
False. You can't materialize the value from either erased or end.
So the use case for this is:
auto itr = find some value
if (itr)
do something with the value
else
create an entry for the key and value
7 tasks
|
Since CI fixes are required for buildkite build, I created a new PR: #997 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Added bool operator to KV table iterator so that developers can easily check if the iterator exists by using an
if (itr) {}statement.Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions